Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetraf-3602: Update to use aws-sdk >= 2.1562 #229

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

dflanigan
Copy link
Contributor

@dflanigan dflanigan commented Feb 21, 2024

6.1.2

Updates to work with S3 client of aws-sdk 2.1562.0:

  • Use the default value of HighWaterMark for the WriteStream interface. With the updated aws-sdk version, the HighWaterMark setting was causing write timeouts.
  • New version of aws-sdk does not reliably call the callback fuction of put_object. tilelive depended on that call back to count the number tiles being written. When the callback was not being called tilelive would hang. The solution is just use the finish event that tilelive to indicate that all of the tiles have been written. If an error occures tilelive will catch the error event.

@dflanigan dflanigan requested a review from markmisener March 26, 2024 17:51
@dflanigan dflanigan merged commit aba84ad into master Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants