Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS: this PR can use some help from other folks - it deals with NPM integration, which turns out is not working as intended... :(
The martin-ui dir must be part of the martin package, otherwise it does not get included in the
cargo publish -p martin
. We could also do it with a symlink from inside the/martin
dir, but that gets a bit confusing - easier to just keep ui inside martin itself, as it is not used anywhere outside of that crate.In order to prevent these bugs in the future, we might want to run
cargo +nightly publish --workspace -Z package-workspace --dry-run
as part of some CI -- this will take into account that some crates depend on the other, and that some/all of them have not been published yetTODO
martin/build.rs
to install node files inside the standard build dir. Current dry run shows this error:I am not sure we should use
--no-verify
fixes #1667