Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves Unimplemented type: 3 error for geojson format #1465

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: resolves Unimplemented type: 3 error for geojson format #1465

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea85ddd
fix: resolves Unimplemented type: 3 error for geojson format
rjdjohnston Feb 13, 2025
d7a63bd
fix: removing duplicate zlib import
rjdjohnston Feb 26, 2025
fe510fb
fix: remove redundant change to headers
rjdjohnston Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/serve_data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { openMbTilesWrapper } from './mbtiles_wrapper.js';

import fs from 'node:fs';
import { fileURLToPath } from 'url';

const packageJson = JSON.parse(
fs.readFileSync(
path.dirname(fileURLToPath(import.meta.url)) + '/../package.json',
Expand Down Expand Up @@ -113,12 +114,14 @@ export const serve_data = {
let headers = fetchTile.headers;
let isGzipped = data.slice(0, 2).indexOf(Buffer.from([0x1f, 0x8b])) === 0;

if (isGzipped) {
data = await gunzipP(data);
isGzipped = false;
}
delete headers['Content-Encoding'];
Copy link
Collaborator

@acalcutt acalcutt Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think this delete headers['Content-Encoding']; line is needed, won't it just be updated to gzip anyway on line 159
headers['Content-Encoding'] = 'gzip';

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. updated.


if (tileJSONFormat === 'pbf') {
if (options.dataDecoratorFunc) {
if (isGzipped) {
data = await gunzipP(data);
isGzipped = false;
}
data = options.dataDecoratorFunc(
req.params.id,
'data',
Expand Down Expand Up @@ -259,8 +262,8 @@ export const serve_data = {

let data = fetchTile.data;
var param = {
long: bbox[0].toFixed(7),
lat: bbox[1].toFixed(7),
long: bbox[0],
lat: bbox[1],
Comment on lines +264 to +265
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional. I think we purposely limited this to 7, but if it is causing an issue I am fine with reverting it.

encoding,
format,
tile_size: TILE_SIZE,
Expand Down
Loading