Refactor analysis_ops to allow users to specify a plot quality attribute #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to organize the code in a way where it makes sense to pull out the individual plotting routines to allow different functions to produce different quality plots (e.g. a publication-level plot may take more time to plot than a simple contour plot on the native grid, but we want to be able to produce both)
_plot_climo() still loops over variables, time periods, and levels, but the loop over datasets and the actual plotting is moved to _gen_plots()
_get_fancy_plots() and _get_fancy_plot() push Matt's adjust_pop_grid() further into the code to make it easier to avoid calling them when we just want to use da.plot()
Note that this requires esmlab at commit bbad55c or later (commit made June 7, 2019); I won't merge this PR until I can verify that it runs with a released version of esmlab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let users choose between a publication-quality plot and something that can be produced faster (and also add hooks for additional quality levels in between).