Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: todo.rs example and some fixes #1108

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Conversation

marc2332
Copy link
Owner

NVIDIA_Overlay_EHVakbLMjV.mp4
  • DragZone will only dragging for the left mouse button
  • more conservative compositor caching area inflation
  • Made the Popup be global positioned
  • Fixed that that the global position was not using the position_top and the other position attributes

@marc2332 marc2332 added enhancement 🔥 New feature or request fix 🩹 Fixes a bug labels Feb 11, 2025
@marc2332 marc2332 added this to the 0.3.0 milestone Feb 11, 2025
Copy link

Benchmark for 07010cd

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 114.2±0.56ms 112.8±0.30ms -1.23%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 26.4±1.00ms 25.2±0.66ms -4.55%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1474.7±22.11µs 1473.4±13.46µs -0.09%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 138.6±1.34µs 138.6±1.46µs 0.00%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.7±0.91ms 24.1±0.46ms -9.74%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1788.1±45.37µs 1761.8±39.04µs -1.47%
benchmarks/size=19531 depth=7 wide=5 mode=cached 343.7±10.89µs 311.0±6.80µs -9.51%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.0±0.14ms 2.8±0.02ms -6.67%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 431.2±62.22µs 431.7±126.10µs +0.12%
benchmarks/size=54241 depth=5 wide=15 mode=cached 326.9±64.20µs 242.3±5.84µs -25.88%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.3±0.41ms 6.7±0.03ms -8.22%

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 87.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.89%. Comparing base (8d0dd30) to head (453d8cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/torin/src/values/position.rs 78.37% 8 Missing ⚠️
crates/components/src/drag_drop.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   74.89%   74.89%   -0.01%     
==========================================
  Files         231      231              
  Lines       28416    28423       +7     
==========================================
+ Hits        21282    21287       +5     
- Misses       7134     7136       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark for b890d33

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 112.5±1.75ms 113.5±0.74ms +0.89%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 27.4±0.94ms 26.9±1.21ms -1.82%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1470.4±10.05µs 1477.3±12.95µs +0.47%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 139.4±6.34µs 140.1±6.05µs +0.50%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.2±0.72ms 25.6±0.37ms -2.29%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1786.2±21.10µs 1773.9±8.38µs -0.69%
benchmarks/size=19531 depth=7 wide=5 mode=cached 314.1±6.66µs 317.4±10.28µs +1.05%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.8±0.07ms 2.8±0.02ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 430.8±55.24µs 434.8±95.82µs +0.93%
benchmarks/size=54241 depth=5 wide=15 mode=cached 269.2±160.65µs 259.9±24.57µs -3.45%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.8±0.27ms 6.8±0.19ms 0.00%

@marc2332 marc2332 marked this pull request as ready for review February 12, 2025 20:08
Copy link

Benchmark for 6accbec

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 113.6±1.58ms 113.7±0.93ms +0.09%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 27.7±0.61ms 27.9±1.26ms +0.72%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1495.2±16.43µs 1505.4±17.46µs +0.68%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 142.6±1.90µs 142.4±5.09µs -0.14%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.7±0.37ms 26.5±0.53ms +3.11%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1843.5±94.84µs 1801.8±22.08µs -2.26%
benchmarks/size=19531 depth=7 wide=5 mode=cached 319.7±6.74µs 316.9±10.23µs -0.88%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.0±0.03ms 2.8±0.02ms -6.67%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 439.0±68.22µs 437.2±33.81µs -0.41%
benchmarks/size=54241 depth=5 wide=15 mode=cached 261.1±17.46µs 261.9±21.32µs +0.31%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.9±0.10ms 6.8±0.11ms -1.45%

Copy link

Benchmark for 518e912

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 115.2±2.97ms 114.9±2.65ms -0.26%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 27.6±0.79ms 27.8±1.22ms +0.72%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1518.1±93.29µs 1513.2±19.40µs -0.32%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 141.6±1.50µs 142.5±2.31µs +0.64%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.9±0.88ms 25.8±0.37ms -0.39%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1842.6±111.45µs 1837.3±37.62µs -0.29%
benchmarks/size=19531 depth=7 wide=5 mode=cached 329.4±14.19µs 318.0±6.36µs -3.46%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.0±0.03ms 2.9±0.03ms -3.33%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 442.7±100.43µs 443.3±49.03µs +0.14%
benchmarks/size=54241 depth=5 wide=15 mode=cached 256.4±27.19µs 259.9±29.02µs +1.37%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.9±0.12ms 6.9±0.16ms 0.00%

@marc2332 marc2332 merged commit be6428b into main Feb 13, 2025
9 checks passed
@marc2332 marc2332 deleted the feat/todo-example-and-fixes branch February 13, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request fix 🩹 Fixes a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant