-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo animations #902
base: main
Are you sure you want to change the base?
Redo animations #902
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 76.06% 75.77% -0.29%
==========================================
Files 207 207
Lines 23296 23383 +87
==========================================
Hits 17719 17719
- Misses 5577 5664 +87 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if a new struct is the right API, I feel like this should be built into AnimNum and AnimColor instead, wdyt?
It already is a replacement for AnimValue, we could just replace AnimValue with it and make an AnimVolor variant for that. I also have no idea how to fix the is_running method on it rn as idk how the index is given. |
What do you mean by a variant? Like an enum variant? Wouldn't that be the same as having two structs? |
I meant it as an another struct, its just simmilar enough that i called it a variant of the original |
yeah but the thing is that the only difference is that you can have multiple steps, I just feel like we could just move this into the other two structs somehow |
Yeah, we can do that |
72e7d03
to
2819375
Compare
This should make it a lot easier to make animations that consist of multiple easing function run one after another.