OpenSSL::Digest::Digest is deprecated; use OpenSSL::Digest instead #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. When was OpenSSL::Digest.new introduced? My concern with this change is versions of ruby that don't yet have it will fail here. Could you just wrap it in a respond_to? check? |
|
OpenSSL::Digest has been available since 1.8.7. I've added the respond_to? check. |
|
Thanks Matthew. |
marcel
added a commit
that referenced
this pull request
Feb 21, 2014
OpenSSL::Digest::Digest is deprecated; use OpenSSL::Digest instead
|
Any chance a new release could be cut to ship this? |
|
yup...a new release would be much appreciated. Thanks! |
|
I too would appreciate a new release, or failing that, if it is easy to do, instructions on how to clone and build my own version of the gem locally. |
|
👍 new version would be great. |
|
It is close to 3 months since this has been merged to master, please consider releasing a new version |
|
Still have this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #91 by replacing OpenSSL::Digest::Digest (which is deprecated and produces a warning in Ruby 2.1.0) with OpenSSL::Digest