Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounds too restrictive (for Nix) #2

Open
someodd opened this issue Aug 7, 2022 · 4 comments
Open

Bounds too restrictive (for Nix) #2

someodd opened this issue Aug 7, 2022 · 4 comments

Comments

@someodd
Copy link

someodd commented Aug 7, 2022

This library has been a joy to use, I really like it--good work.

I noticed something when attempting to use Nix for my project. libjwt-typed is marked as broken. I was able to progress far enough to realize some simple fixes (mark libjwt as system dependency was one), but the one I'm writing you about is the version bounds for base in your project. In my project I use base 4.14.3.0 and everything plays nice. However, Nix seems to only provide base 4.16.3.0, but the bounds of libjwt-typed for base seems to be >=4.13.0.0 && <4.15.

Is there anyway to change the bounds to be more flexible? I may even test out 4.16.3.0 specifically with libjwt-typed (and subsequently make a PR) once I resolve something locally. Thank you.

@marcin-rzeznicki
Copy link
Owner

Thank you very much! Nice to hear it. I have to admit I was neglecting this library a bit and was not keeping up with the dependencies marching forward (I believe that it's got kicked out of Stackage). That said, I am actually working on a rewrite to get things tidied up and bring it up to date. I've also not been too happy with libjwt (C dependency) and I will probably get rid of it and just use GnuTLS + JSMN directly. But this re-work has been going very slow, so there is no point in waiting for it to happen. If you are willing to test it, I will gladly change the bounds and make a new revision on Hackage. In case something in the code needs to be changed, we'll simply make a new release. Thank you very much!

@someodd
Copy link
Author

someodd commented Aug 10, 2022

I got things to work by simply by making a cabal.project:

packages: *.cabal

allow-newer:
  libjwt-typed:base,
  libjwt-typed:text

... instead of using --allower-newer, which would present an issue with a later version MonadTime removing an instance that libjwt-typed uses.

Would you like me to make a PR to increase the bounds for text and base?

@marcin-rzeznicki
Copy link
Owner

Sure! Thank you very very much!

someodd added a commit to someodd/libjwt-typed that referenced this issue Aug 12, 2022
Resolve the issue of this package not building
for GHC 9.0.2 due to `base` and `text` bounds
being too restrictive by simply slightly
increasing the freshest/upper bound for both.

Tests have not been manually ran for this commit.
Assuming all works well because I'm using
libjwt-typed with nixpkgs in my project that now
uses GHC 9.0.2.
@someodd
Copy link
Author

someodd commented Aug 12, 2022

@marcin-rzeznicki done! You may want to run tests on it, because I have not. Please see commit notes.

#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants