Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated componentWillMount with componenDidMount #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rlamana
Copy link

@rlamana rlamana commented Apr 27, 2019

componentWillMount is deprecated in react 16.3 and some linters and frameworks (like Gatsby) fail to build due to the use of the deprecated method componentWillMount. The method is only used to add event listeners which is safer to do with componentDidMount.

@rlamana
Copy link
Author

rlamana commented Jun 3, 2019

@marcio any feedback/review on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant