Add io wait callback for blockin io operations. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a io wait callback that will be called instead of base io witing handlers.
9EOR9
reviewed
Jan 15, 2018
| @@ -208,6 +208,7 @@ extern const char *SQLSTATE_UNKNOWN; | |||
| /* MariaDB specific */ | |||
| MYSQL_PROGRESS_CALLBACK=5999, | |||
| MYSQL_OPT_NONBLOCK, | |||
| MYSQL_OPT_IO_WAIT, | |||
There was a problem hiding this comment.
New options (which are not supported by MySQL server should be prefixed with MariaDB and should be added to the end of enumeration.
9EOR9
reviewed
Jan 15, 2018
| @@ -316,6 +317,7 @@ struct st_mysql_options { | |||
| int (*local_infile_error)(void *, char *, unsigned int); | |||
| void *local_infile_userdata; | |||
| struct st_mysql_options_extension *extension; | |||
| int (*io_wait)(my_socket handle, my_bool is_read, int timeout); | |||
There was a problem hiding this comment.
This should be added to mysql->options.extension to avoid ABI breakage.
9EOR9
reviewed
Jan 15, 2018
| @@ -2716,6 +2716,9 @@ mysql_optionsv(MYSQL *mysql,enum mysql_option option, ...) | |||
| } | |||
| mysql->options.extension->async_context= ctxt; | |||
| break; | |||
| case MYSQL_OPT_IO_WAIT: | |||
| mysql->options.io_wait = (int(*)(my_socket, bool, int))arg1; | |||
There was a problem hiding this comment.
callback should be registered in mysql->options.extension->io_wait
|
Replaced by PR #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a io wait callback that will be called instead of base io witing
handlers.
We use mariadb-connector-c for our mariadb/mysql connector https://github.com/tarantool/mysql for tarantool nosql database https://github.com/tarantool/tarantool.
Mariadb connector uses own internal fiber implementation for async operations and need to special wrap for async api function (_start/_cont), but tarantool already has it own fibers.
I added one option for mysql connection that allowed callback from pvio objects for io polling, in this case standart api calls can be used asynchronously without wrapping, because we will need to call some more methods that already exist in future (ex. for replication from mariadb databases).
Little example can be found at our git repo https://github.com/tarantool/mysql/blob/master/mysql/driver.c