Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work multiselect component #4376

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Conversation

OsamaAbdellateef
Copy link
Contributor

@OsamaAbdellateef OsamaAbdellateef commented Jan 9, 2025

Description

Please include a summary of the change and which issue is fixed when no corresponding ticket is available. Add additional informations the reviewers should know.

  • This change requires a UI-Kit update - inform Alex Tirado (@tirado-rx)

What should be tested?

Are they some special informations required to test something?

Reviewers:

Which persons should review this PR? Add person with @mentions

Examples:
@marigold-ui/developer
@marigold-ui/designer

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: fd68f17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ❌ Failed (Inspect) Jan 31, 2025 1:38pm
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:38pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:38pm

@github-actions github-actions bot added the type:feature New feature or component label Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.33% (-0.11% 🔻)
8867/8927
🟢 Branches
90.84% (-0.05% 🔻)
476/524
🟢 Functions
98.2% (-0.47% 🔻)
164/167
🟢 Lines
99.33% (-0.11% 🔻)
8867/8927
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Multiselect2.tsx
96.69% 100% 93.75% 96.69%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / HelpText.tsx
97.83% (-2.17% 🔻)
76.92% (-23.08% 🔻)
100%
97.83% (-2.17% 🔻)
🟢
... / Input.tsx
98.72% (-1.28% 🔻)
80% (-20% 🔻)
100%
98.72% (-1.28% 🔻)
🟢
... / ProgressCycle.tsx
96.36% (-3.64% 🔻)
50% (-50% 🔻)
100%
96.36% (-3.64% 🔻)

Test suite run success

620 tests passing in 81 suites.

Report generated by 🧪jest coverage report action from fd68f17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant