feat(overlay): allow passing HTMLElement #4463
Conversation
wip: pass html element wip: add test for ssr case wip: add test for the fallback wip: fix unit test wip: code refactoring
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@imdhemy is attempting to deploy a commit to the Marigold Team on Vercel. A member of the Team first needs to authorize it. |
| : portalContainer | ||
| ? document.getElementById(portalContainer) | ||
| : document.body; | ||
| if (useIsSSR()) return null; |
There was a problem hiding this comment.
I kept this logic, but why isn't this available for SSR?
Description
Context:
We use a custom HTML element with a shadow root to render our application. This encapsulates our element from the document's DOM, preventing it from accessing main document elements.
Currently, the
OverlayContainerProviderexpects an element ID and retrieves it usingdocument.getElementById(portalContainer). However, this approach fails in our use case, as the query always returnsnulldue to shadow DOM encapsulation. Additionally, there is nobodyin our case, which further limits our ability to append overlays to the standard document structure.This PR:
Adds support for passing an
HTMLElementdirectly to theOverlayContainerProvider.Preserves the existing behavior of accepting an element ID.
Enhances and fixes unit tests for
OverlayContainerProvider.This change requires a UI-Kit update - inform @tirado-rx @benjirsvx
What should be tested?
body.Are they some special informations required to test something?
Reviewers:
Which persons should review this PR? Add person with @mentions
Examples:
@marigold-ui/developer
@marigold-ui/designer