Adding Gooey as an easier way to provide arguments #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first crack at adding GUI to the script. It's definitely not a full blown GUI , but hopefully good enough and an easy way to do it. I won't be offended if this is not the direction you want to take the project :)
It gets very messy and complicated if I run gui and non-gui versions of the code in the same file (have to make a fake decorator, have to add all those extra options to CLI args, etc), so I opted to put gui code to a separate file. This required small modifications to run.py, but it mostly involved moving things into different functions.
Since the goal was to be able to adjust config in the GUI, I have added extra options to it. Their default values are set to what's already in the config and upon execution of the script those values are saved to the conf.toml file, so they persist between code execution and the rest of the code doesn't need to be aware of the GUI at all.
The -noprofile command is to tell powershell to not load the user profile and it doesn't affect the functionality, but without it on my machine Gooey version of the script generates an error when playing sound.
Currently there's a bug between Gooey and the wxpython 4.1.0, so I have to specify an earlier version in the requirements manually.
I have done some limited testing and things appear to work just fine, but I didn't try everything.