Skip to content

Conversation

mgsmus
Copy link

@mgsmus mgsmus commented Jan 13, 2017

No description provided.

@chrisjeon
Copy link

@mgsmus It just looks like it's failing because the automated tests are not recognizing the jQuery 3 commands like on('load'). Try adding a jquery 3 version like 3.2.1 in this line https://github.com/markdalgleish/stellar.js/blob/master/Gruntfile.js#L48

Also, the version will have to be bumped up since it looks like this change will break previous versions of stellar.js running on older versions of jQuery.

@Thanaen
Copy link

Thanaen commented Mar 26, 2019

These changes have been approved, but I cannot find an associated release. Is the tavis-ci fail blocking a release? What's happening with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants