Skip to content

Add REST for files #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Add REST for files #3

merged 2 commits into from
Dec 12, 2024

Conversation

DecafMangoITMO
Copy link

Обновил схему файла: нам достаточно знать название и содержимое файла

Из REST добавлены методы:

  • GET (для получения файла по ИД)
  • POST (для создания файла - мы договорились, что могут существовать файлы с одинаковым именем)
  • DELETE (для удаления по ИД)

Не были добавлены запросы на обновление файла, т.к. этим будет заниматься другой процесс через сокеты

@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 563f7ee095ff32d532825740e9189fd6274cbfb1-PR-3

Details

  • 6 of 52 (11.54%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.7%) to 22.785%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/backend/files/file_registry.ex 3 4 75.0%
lib/backend/files/file.ex 0 2 0.0%
lib/backend_web/router.ex 0 3 0.0%
lib/backend_web/channels/room_channel.ex 0 5 0.0%
lib/backend/files/file_manager.ex 3 9 33.33%
lib/backend/files/files.ex 0 6 0.0%
lib/backend/files/file_process.ex 0 10 0.0%
lib/backend_web/controllers/file_controller.ex 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
lib/backend_web/channels/room_channel.ex 1 0.0%
Totals Coverage Status
Change from base Build d1d0b9c43b0b48e29dd3318a9420c8f04bd1cabf: -2.7%
Covered Lines: 54
Relevant Lines: 237

💛 - Coveralls

Copy link

@Romariok Romariok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит норм

@Romariok Romariok requested review from worthant and removed request for worthant December 12, 2024 21:49
Copy link
Member

@worthant worthant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

very good approach, i like this code

@worthant worthant merged commit ef4c9fd into main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants