Migrate CI to GitHub Actions (v2) #222
Open
+60
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: - [email protected] dropped support for Python <= 3.8 - [email protected]+ broke mir_eval. A fix was merged in mir_eval@main but has not been released yet - see: mir-evaluation/mir_eval#352 - [email protected] brakes mir_eval - see: mir-evaluation/mir_eval#383 - i updated pytest hoping it would help solve failing tests but that's a HUGE v3—>v8 jump. I only made the bare minimum of fixes to accomodate this upgrade, and I would expect more work is needed - i wanted to add python 11/12 support but delayed this until we can already get tests runnning properly on 3.9/3.10
bmcfee
reviewed
Feb 19, 2025
giovana-morais
changed the title
bmcfee
reviewed
Feb 19, 2025
|
mir_eval 0.8.1 is on pypi now; should hit conda-forge by this afternoon. |
add support for python 3.9
i ran the sonify tests and some are failing but for a different reason now. i'll mark those as xfail again and i can investigate and provide more details afterward in the other than this, i added back the support to python 3.9 by using |
giovana-morais
commented
Feb 21, 2025
| for ns in chain(*map(lambda p: p.rglob('*.json'), resources.files('jams.schemata.namespaces').iterdir())): | ||
| schema.add_namespace(ns) | ||
| if sys.version_info < (3, 10): | ||
| from pkg_resources import resource_filename |
There was a problem hiding this comment.
thought that leaving the import statement here might be better than at the beginning of the code to avoid deprecation warning for newer python versions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #217 (unfortunately, i can't add commits to his branch)
changelog
sonifymodule. as far i understand, the fix for the errors we were seeing is in the next release (0.8.1)