deletionView and onSubmitSuccess/onSubmitError #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onSubmitSuccess/onSubmitError added to deletion view
This reverts commit b40b8da.
|
Due to unfortunate usage of bash on windows at the moment (need some time to build my linux machine) I cannot run tests and thus unable to fix test case to follow my changes. |
|
OK, the initial error due to test case not being update is gone. But again I don't understand check failed error message "No selenium server jar found at", can someone please see what happened and why please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1106 and obsoletes (already closed) #1111.
admin-config pull request marmelab/admin-config#67 needed for this to function!