-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the code #149
Open
MarcSteven
wants to merge
100
commits into
bugfix/issue74
Choose a base branch
from
master
base: bugfix/issue74
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Optimize the code #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+Fix for issue #74
unzip file handler support
support swift 4.0
…ation Add fwrite() and uncompressed_size validation
Enables zipping of directory contents, i.e. not including root directory in zip. Equivalent to user cd'ing into directory and zipping. Functionality left as default, but logic is now there to enable above by either toggling boolean, or modifying other functions to enable toggling per call. Also, expandDirectoryFilePath function comment changed. It's not a recursive function :)
Fix Swift 4 string compiler deprecation warning.
Added includeRootDirectory logic.
String warnings
After upgrading to Xcode 9.3, I get the following error: dyld: Library not loaded: @rpath/libswiftCore.dylib Referenced from: /Users/chris/Library/Developer/CoreSimulator/Devices/.../data/Containers/Bundle/Application/.../RE-vibe.app/Frameworks/Zip.framework/Zip Reason: image not found I have tried several different approaches, but none have fixed the issue. I suspect the the swift version for this package needs to be upgraded to match Xcode 9.3's version.
Add Swift Package Manager support
Progress block being called twice with 1.0 fixed
Xcode12 support
Enable module stability support to allow build as binary release and used for different version of Xcode, it can save app build time. see more on https://swift.org/blog/library-evolution/
Xcode 13 RC compile fix
Enable Module Stability and Adds script to build xcframework
…versal_vulnerability Protect against extracting files outside the destination directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code ,remove unreleased code out of zip class