Skip to content

Commit

Permalink
[hotfix]: invalid output location when generating artifacts
Browse files Browse the repository at this point in the history
  • Loading branch information
marouenes committed Jan 19, 2023
1 parent b0d5f16 commit 889d08f
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
28 changes: 28 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
.PHONY: help dev test clean

default: help

help:
@echo 'Makefile for the project'
@echo
@echo 'Usage:'
@echo ' make dev install the packages in development mode'
@echo ' make lint run linter'
@echo ' make test run tests'
@echo ' make clean clean all auxiliary files, build and test compiled files'
@echo

dev:
# install the package in development mode
python -m pip install --upgrade pip
pip install -e .[dev]

test:
# run unit tests and generate coverage report
python -m pytest tests/ -vv --cov=. --cov-report=html --cov-report=term-missing --junitxml=junit/coverage-results.xml

clean:
# clean all auxiliary files, build and test compiled files
@rm -rf .pytest_cache/ */.pytest_cache/ junit/ build/ dist/ htmlcov/ .coverage
@find . -not -path './.venv*' -path '*/__pycache__*' -delete
@find . -not -path './.venv*' -path '*/*.egg-info*' -delete
2 changes: 1 addition & 1 deletion imdb_rating_classifier/generate.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def main(ctx: click.Context) -> None:
@click.option(
'--output',
type=click.Path(exists=False, file_okay=True, dir_okay=False),
default=f'{BASE_DIR}/data/movies.csv',
default='movies.csv',
help='The path to the output file.',
)
@click.option(
Expand Down

0 comments on commit 889d08f

Please sign in to comment.