feat: update symfony dependencies #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
reviewed
Jan 26, 2024
oliverklee
approved these changes
Jan 26, 2024
martin-helmich
requested changes
Jan 26, 2024
|
Yes, v7 is now added. I replaced the |
oliverklee
approved these changes
Jan 27, 2024
…orking with php8.2)
oliverklee
approved these changes
Jan 27, 2024
martin-helmich
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
So, this looks good in general 👍 -- 867a2bf was a good catch, I didn't remember we had that workaround in there. Only reason the tests are still failing is because the upstream library helmich/typo3-typoscript-parser is not yet compatible with the symfony v7 libraries; I'll see if we can bump these as well...
|
Waiting for martin-helmich/typo3-typoscript-parser#95 to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with newer version of symfony packages: works like a charm!