Fix some Clang warnings #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: unused variable 'nullopt' [-Wunused-const-variable]
2284 | const nullopt_t nullopt{};
| ^~~~~~~
warning: unused variable 'u' [-Wunused-variable]
610 | nonstd::unexpected<int> u{7};
| ^
Clang complains:
warning: 'value' is deprecated: replace value() with error() [-Wdeprecated-declarations]
2333 | using ContainedEx = typename std::remove_reference< decltype( get_unexpected().value() ) >::type;
| ^
|
Thanks! |
martinmoene
added a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A plain
cmake .. ; makeon OSX with the stock Clang gives some warnings that look easy to fix; so, I fixed them.The second commit, re
decltype( get_unexpected().value() ), merits a close look, because the old code seems so weird (your code using a method that you yourself deprecated). There might be something sneaky going on there.