Fix failing Clang builds on GitHub Actions #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while ago the 'ubuntu-latest' image moved from Ubuntu 22.04 to Ubuntu 24.04. See <actions/runner-images#10636>. However, Ubuntu 24.04 does not have packages for Clang 11 and 12 anymore, thus the Clang jobs failed when they tried to install the corresponding compilers. Therefore, the workflow is changed to use 'ubuntu-22.04' instead of 'ubuntu-latest'. Furthermore, jobs for Clang 16 (the first major version of Clang to support `std::expected`) and Clang 19 (latest Clang version available on Ubuntu 24.04) are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago the
ubuntu-latestimage moved from Ubuntu 22.04 to Ubuntu 24.04. See actions/runner-images#10636. However, Ubuntu 24.04 does not have packages for Clang 11 and 12 anymore, thus the Clang jobs failed when they tried to install the corresponding compilers. Therefore, the workflow is changed to useubuntu-22.04instead ofubuntu-latestfor Clang 11 and Clang 12.Furthermore, jobs for Clang 16 - the first major version of Clang to support
std::expected- and Clang 19 (latest Clang version available on Ubuntu 24.04) are added.The reason for those additions is basically martinmoene/nonstd-lite-project#75. Since Clang 11 and 12 do not support
std::excepted, there should also be some tests with Clang versions that do. Clang 16 is the obvious choice here, because it is the first Clang version that comes with built-in support forstd::expected. Clang 19 is just the latest Clang currently available via Ubuntu package respositories. I think that is a good choice to catch potential problems with the latest Clang.