Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/position nad change command format #11

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

/position nad change command format #11

wants to merge 5 commits into from

Conversation

Utlamo
Copy link
Contributor

@Utlamo Utlamo commented Dec 15, 2022

  • edit /position command/permision/tabCompleter/file directory
  • Move to TabExecuter format

Utlamo and others added 5 commits December 15, 2022 15:43
@Utlamo
Add to config option to disable auto update
ea4d9aa
@Utlamo
Bugfix for /warp when player don't use full warp name
fe7ae22
@marylieh @Utlamo
Update release version from 3.4 to 3.5
ad57a07
@Utlamo
Move to TabExecutor standard
314651d 
- move file from commands/position/PositionCommandExecutor to commands/PositionCommand
- rename file from WarpCommandExecutor to WarpVersionCommand etc.
@Utlamo
Change /position options and add tab completer
0c8d5c9 
- change permision (look READ.ME)
- add tab completer
@Utlamo
Copy link
Contributor Author

Utlamo commented Dec 15, 2022

Idk what i bad write there.
src/main/kotlin/me/marylieh/simplewarp/commands/WarpCommandExecutor.kt
is now
src/main/kotlin/me/marylieh/simplewarp/commands/WarpCommand.kt

marylieh
marylieh requested changes Jan 15, 2023
View reviewed changes
Copy link
Owner

@marylieh marylieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Maybe add an option to change to syntax from the position command so the User has the option to use the old or the new syntax.
  • Add an empty line at the end of each file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marylieh marylieh marylieh requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Utlamo @marylieh