Update and remove links to old examples #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo-Besancon
requested changes
Jan 10, 2024
There was a problem hiding this comment.
This link still leads to 404:
https://github.com/massalabs/web3-utils/blob/main/src/arguments.ts#L42
("You can learn more about Args via the source code")
Also: "A complete example of how to use the Wallet API is also available."
Ben-Rey
force-pushed
the
259-link-to-example-in-massa-web3-is-not-valid
branch
from
fe94fbd to
8ac1471
Compare
Ben-Rey
force-pushed
the
259-link-to-example-in-massa-web3-is-not-valid
branch
from
8ac1471 to
d61d377
Compare
Leo-Besancon
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
The only remaining thing for me is that the Mainnet tab here is broken, but we could just do it in another PR if you want to merge this one ;)
https://docs.massa.net/docs/build/massa-web3#without-wallet-provider
Fixed thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.