-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart contract #1
Conversation
Co-authored-by: Damir Vodenicarevic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file structure is weird. Why is there a smart-contract folder that wraps everything ?
I don't understand why you use let for variables that do not change. Isn't it more time and space complex than const ?
Why don't you use expect + error message when deserializing user inputs ?
This repository will also contains the website that will made for this project under another subdirectories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the full code source for the DNS smart contract. This contract should match the NFT standard of Massa (inspired from ERC721), the RFC of the DNS SC here (with adjustments for NFT standards) and implement all features listed here
The two main files are
smart-contract/assembly/contracts/main.ts
: Source code of the smart contractsmart-contract/assembly/__tests__/dns.spec.ts
: Tests for each function of the smart contract@damip Can you ensure the smart contract match all the needs please.
@gregLibert and @leoloco can you review the code please.