New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant words in comment #4780

Open

HongKuang wants to merge 1 commit into massalabs:mainnet_2_3 from HongKuang:main

+6 −6

HongKuang commented Dec 3, 2024

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification


          chore: remove redundant words in comment

aa5a391

Signed-off-by: hongkuang <[email protected]>

sydhds requested review from sydhds and Leo-Besancon

December 3, 2024 14:09

Leo-Besancon approved these changes

View reviewed changes

sydhds changed the base branch from main to mainnet_2_3

January 2, 2025 10:49

Contributor

sydhds commented Jan 2, 2025

Hi @HongKuang, would you mind rebasing your PR on top of branch mainnet_2_3? This would allow us to investigate why the CI is failing on your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet