Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several bootstrap improvements #4866

Open
wants to merge 7 commits into
base: mainnet_2_3
Choose a base branch
from
Open

Several bootstrap improvements #4866

wants to merge 7 commits into from

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Feb 27, 2025 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Solves:

  • Bad error handling (SlotTooOld error was not propagated correctly to client)
  • Increase the default final_history_length to be consistent with the bootstrap default timeouts
  • Avoid filling RocksDB read cache when iterating for bootstrap

@Leo-Besancon Leo-Besancon changed the title retrun SlotTooOld error in case of cache miss return SlotTooOld error in case of cache miss Feb 27, 2025
@Leo-Besancon Leo-Besancon changed the title return SlotTooOld error in case of cache miss Improve bootstrap error handling and history Feb 27, 2025
@Leo-Besancon Leo-Besancon linked an issue Feb 27, 2025 that may be closed by this pull request
Several bootstrap improvements #4865
Open
@Leo-Besancon Leo-Besancon changed the title Improve bootstrap error handling and history Several bootstrap improvements Feb 28, 2025
@Leo-Besancon Leo-Besancon force-pushed the fix_bootstrap_error_handling branch from 2e93bf5 to a135a34 Compare February 28, 2025 11:37
@Leo-Besancon Leo-Besancon marked this pull request as ready for review February 28, 2025 11:41
@Leo-Besancon Leo-Besancon requested a review from modship February 28, 2025 13:09
@Leo-Besancon Leo-Besancon force-pushed the fix_bootstrap_error_handling branch from 89f9345 to 5a30c0e Compare March 3, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modship modship Awaiting requested review from modship

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several bootstrap improvements
1 participant
@Leo-Besancon