Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add draft warning about post visibility #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ratsclub
Copy link
Member

@ratsclub ratsclub commented Jul 17, 2024

This introduces a small textual warning regarding draft visibility.


image

@sirodoht
Copy link
Member

Thanks! This is great! I have some reservations about the design. I'll get back to you when I look better into it!

@ratsclub
Copy link
Member Author

One idea, instead of adding this huge warning, we add a Share link/Copy link to the button action. What do you think?

image

@sirodoht
Copy link
Member

Hmm interesting. Yeah, that could be better. But we would need JavaScript to copy it. Maybe we could have a non-JavaScript option as well.

@thiagokokada
Copy link

thiagokokada commented Aug 15, 2024

IMO, I think I prefer the first solution since share link is still not clear what is happening (and also I don't think this feature needs to depend on JavaScript).

However one thing, I think that the warning should only appear for logged in users (or even better, only for the author). For whatever who receives the link, they don't need to care about this detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants