Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .cbr mimetype #614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix .cbr mimetype #614

wants to merge 1 commit into from

Conversation

janek37
Copy link

@janek37 janek37 commented Jun 14, 2024

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I really don't know much about mimetype naming, this builds without issue. A test .cbr file opened fine both with and without this, so not sure what the best test of this is.

@lukefromdc lukefromdc requested a review from a team June 20, 2024 23:46
@janek37
Copy link
Author

janek37 commented Jun 21, 2024

While I really don't know much about mimetype naming, this builds without issue. A test .cbr file opened fine both with and without this, so not sure what the best test of this is.

I'm sorry, I should have added more context. The main issue from my perspective is that thumbnails aren't being generated for .cbr files unless I manually edit /usr/share/thumbnailers/atril.thumbnailer. The correct mimetype for these files can already be found in backend/comics/comicsdocument.atril-backend.desktop.in. Here's the official doc: https://www.iana.org/assignments/media-types/application/vnd.comicbook-rar

@lukefromdc
Copy link
Member

In my case I don't get a thumbnail with or without the applied, but I am not working with anything near a default install so that may be impossible to diagnose

@janek37
Copy link
Author

janek37 commented Nov 28, 2024

This is a really simple change, and easy to verify (e.g. the IANA link above). Why is it not merged yet?

@lukefromdc
Copy link
Member

lukefromdc commented Nov 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect mimetype for .cbr comic files
3 participants