Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard: option to show/select extra layouts #766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oprudkyi
Copy link

@oprudkyi oprudkyi commented Oct 27, 2024

purpose of the feature.
it is really hard to know what option controls that extra layout list, I had spent hours groking why my laptop can show them and desktop can't
so probably it will be useful for newbies and such

P.S. please be extra careful with review - this is my first ever PR into gtk/mate code

@lukefromdc lukefromdc requested a review from a team November 8, 2024 04:33
@oprudkyi
Copy link
Author

Hi @lukefromdc @oz123 @raveit65

Could you please check this

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can verify from a test build that the checkbox works, but I have no way to tell if there is a difference in how many layouts are loaded as there are so many either way I cannot tell the difference.

Going to the code, I see the checkbox toggles the second argument to xkl_config_registry_load() but I have never worked on this part of the code so I really don't know how it works

Note that I know only one language and have never used a different keyboard layout myself. Therefore I have no idea which layouts would be less common.

A proper functional test of this requires knowing one layout that should appear only when the checkbox for less common layouts is checked. If that layout appears when and only when the checkbox is toggled, this PR can be presumed to work.
Any bugs would probably be issues in the existing code in libmatekbd we are toggling.

Also note that much of the team seems to be taking a break at this time, and it is beyond me to solo maintain all of MATE. We really need a review from someone who knows this part of the code.

@lukefromdc lukefromdc requested a review from a team November 19, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants