Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all AdaptiveContainer are displayed correctly #606

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

lixi0912
Copy link

@lixi0912 lixi0912 commented Aug 8, 2024

Description

AdaptiveColumn gutter and row items not showing in some case
AdaptiveNavigationScaffold Use primary variable instead of fixed value

Tests

Test different column span counts to ensure all AdaptiveContainer are displayed correctly

Issues

Checklist

@lixi0912 lixi0912 requested a review from a team as a code owner August 8, 2024 15:54
@lixi0912 lixi0912 requested review from guidezpl and removed request for a team August 8, 2024 15:54
Copy link

google-cla bot commented Aug 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lixi0912
Copy link
Author

rowMainAxisAlignment = MainAxisAlignment.start
image
rowMainAxisAlignment = MainAxisAlignment.center
image
rowMainAxisAlignment = MainAxisAlignment.end
image
rowCrossAxisAlignment = CrossAxisAlignment.start
image
rowCrossAxisAlignment = CrossAxisAlignment.end
image
adjustColumnSpan = true
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant