Allow custom implementations for font data loading. #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new public API, `GoogleFontsLoader`, and a corresponding new instance field `fontLoader` in the global `GoogleFonts.config` class. The new API allows users to hook the loading of fonts into the Flutter engine, which is useful in scenarios where the actual font data is needed for other purposes. The newly added default font loader simply uses Flutter's `FontLoader` as before. Fixes material-foundation#102.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
(CLA now signed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new public API,
GoogleFontsLoader, and a corresponding new instance fieldfontLoaderin the globalGoogleFonts.configclass.The new API allows users to hook the loading of fonts into the Flutter engine, which is useful in scenarios where the actual font data is needed for other purposes. The newly added default font loader simply uses Flutter's
FontLoaderas before.Happy to make any changes!
Description
Any application that wishes to interact with the TTF data for a font retrieved via Google Fonts can use this API to access it. Issue #102 states one such example, using the popular Flutter pdf package to embed text using a font retrieved with this package.
Tests
Added test
loadFontIfNecessary uses specified font loaderand tested API use locally.Issues
Fixes #102
Checklist
CHANGELOG.mdI did not update
CHANGELOG.mdbecause I am not aware of how the maintainers of this package would intend to release this change.