Add check length consistency in additional parameters #459
+789
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilippoOlivo
force-pushed
the
0.2Graph
branch
from
7edcd74 to
a391e18
Compare
FilippoOlivo
force-pushed
the
0.2Graph
branch
from
a391e18 to
d8f9e6f
Compare
FilippoOlivo
added
pr-to-review
FilippoOlivo
force-pushed
the
0.2Graph
branch
2 times, most recently
from
8b263ed to
8120508
Compare
|
@FilippoOlivo Please run the formatter locally |
FilippoOlivo
force-pushed
the
0.2Graph
branch
4 times, most recently
from
59de313 to
fbbadab
Compare
FilippoOlivo
force-pushed
the
0.2Graph
branch
from
fbbadab to
e0ed392
Compare
FilippoOlivo
added
pr-to-fix
gc031298
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Thank you @FilippoOlivo for the nice work. Everything is fine for me!
|
Before merging, let's consider this minor improvement: in some cases, graph features are defined within the model's forward pass, derived from the encoding of other graph attributes (e.g., coordinates, additional parameters). In these situations, it would be helpful to initialize the graph with features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.