UPDATED FFD.PY FILE WITH ROTATION MATRIX AS INPUT #262
+23
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new file allows the user to directly introduce the rotation matrix as input. The attribute rot_mode is created in order to create the rotation matrix through rotation angles (0-value) or to directly introduce the matrix (1-value)
|
Hi @JJab0n could you please provide some tests for this contribution? |
mtezzele
reviewed
Nov 8, 2022
| @@ -93,7 +93,9 @@ def __init__(self, n_control_points=None): | |||
|
|
|||
| self.box_length = np.array([1., 1., 1.]) | |||
| self.box_origin = np.array([0., 0., 0.]) | |||
| self.rot_mode = 0 | |||
There was a problem hiding this comment.
Please add a documentation for the two new members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new file allows the user to directly introduce the rotation matrix as input. The attribute rot_mode is created in order to create the rotation matrix through rotation angles (0-value) or to directly introduce the matrix (1-value).
This option was created to avoid the issue that arises when Euler angles are calculated from the rotation matrix (there is not a single solution). Thereby, the user can directly work with the rotation matrix.