Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for CellsToTeX support #1215

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Checks for CellsToTeX support #1215

wants to merge 2 commits into from

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Mar 31, 2021

rebase of #1104

@rocky
Copy link
Member

rocky commented Mar 31, 2021

Two things that would be super to do.

  1. Squash the 75 or so commits down into those commits that are meaningful and not part of something else. This is done using git rebase -i b0e63ed5eb23fd6c4b9baf922695128405a1de20
  2. Include a copy of CellsToTeX in packages with whatever version changes are useful. We were given the go ahead to do so.

@mmatera
Copy link
Contributor Author

mmatera commented Mar 31, 2021

Two things that would be super to do.

1. Squash the 75 or so  commits down into those commits that are meaningful and not part of something else. This is done using `git rebase -i b0e63ed5eb23fd6c4b9baf922695128405a1de20`

2. Include a copy of CellsToTeX in packages with whatever version changes are useful. We were given the go ahead to do so.

From this PR, the only thing that deserves to be conserved is the test_cellstotex.py file. Now I just copy it in a clean branch of master.

Regarding of leaving a copy, as this is a package that is automatically downloaded from internet, I think that is not a good idea. What maybe makes sense is to have a "loader" that before loading from internet, fix the version of the language (now you need to do that by hand before loading).

@mmatera
Copy link
Contributor Author

mmatera commented Mar 31, 2021

BTW, this version of the tests was marked as xfail, so it can be merged in master without any harm. When the the full support be reached, then the brown dot just will pass to green...

@mmatera mmatera changed the title WIP: CellsToTeX support Checks for CellsToTeX support Mar 31, 2021
@rocky rocky mentioned this pull request Apr 3, 2021
@pytest.mark.xfail
def test_load_and_run():
print("load and run")
str_expected0 = "None"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this should be redone using the helper.

Also in the future tests like this should be moved to mathics_omnibus.

@rocky rocky marked this pull request as draft April 3, 2021 11:34
@rocky rocky force-pushed the master branch 2 times, most recently from b007e8c to ef16eb6 Compare May 19, 2021 22:40
@rocky rocky force-pushed the master branch 5 times, most recently from 8367d69 to 83bb068 Compare June 7, 2021 21:01
@rocky rocky force-pushed the master branch 2 times, most recently from 9570fdd to 499f1bf Compare June 26, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants