CI: Harden GHA configuration #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the possibility of a tag being changed under us.
This eliminates the possibility of a tag being changed under us.
May include: - Avoids risky string interpolation. - Prevents checkout premissions from leaking
Reduces risk of arbitrary code is run by attacker.
Reduces risk of arbitrary code is run by attacker.
QuLogic
reviewed
Jul 22, 2025
| @@ -5,8 +5,13 @@ on: [push, pull_request] | |||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| permissions: | |||
| contents: write | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v4 | |||
.github/workflows/codeql.yml
Outdated
There was a problem hiding this comment.
No actions are pinned in this file.
|
The tool I used to find un-pinned actions (zizmor) does not flag the "official" I suspect the logic is if someone manages to compromise GH there are more direct ways to cause trouble than funny side-band attacks via GHA. |
Co-authored-by: Elliott Sales de Andrade <[email protected]>
|
I think you need to run with the pedantic persona to catch those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply recommended hardening steps including: