Update dependencies #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
commented
Nov 25, 2023
| let format = tracing_subscriber::fmt::format().without_time().pretty(); | ||
| let subscriber = tracing_subscriber::fmt() | ||
| .with_max_level(Level::TRACE) | ||
| .with_writer(MakeJsLogWriter::new()) | ||
| .with_ansi(false) | ||
| .event_format(format) | ||
| .finish(); | ||
| let subscriber = make_tracing_subscriber(None); |
There was a problem hiding this comment.
matrix-org/matrix-rust-sdk#2856 changed the type of JsLoggingSubscriber, and we may as well just use make_tracing_subscriber rather than re-inventing it here.
richvdh
commented
Nov 25, 2023
| @@ -13,7 +13,7 @@ where | |||
| let constructor_name = Object::get_prototype_of(value).constructor().name(); | |||
|
|
|||
| if constructor_name == classname { | |||
| let pointer = Reflect::get(value, &JsValue::from_str("ptr")) | |||
| let pointer = Reflect::get(value, &JsValue::from_str("__wbg_ptr")) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This seems rather brittle but I guess the wbg dependency is pinned anyways 🥲
There was a problem hiding this comment.
totally agree.
We need to get rid of this function anyway, per #51
jplatte
approved these changes
Nov 27, 2023
| @@ -13,7 +13,7 @@ where | |||
| let constructor_name = Object::get_prototype_of(value).constructor().name(); | |||
|
|
|||
| if constructor_name == classname { | |||
| let pointer = Reflect::get(value, &JsValue::from_str("ptr")) | |||
| let pointer = Reflect::get(value, &JsValue::from_str("__wbg_ptr")) | |||
There was a problem hiding this comment.
This seems rather brittle but I guess the wbg dependency is pinned anyways 🥲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.