Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline: Fix a bug where local echoes were showing unencrypted shields. #3788

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 1, 2024

Small fix following on from #3783 as local echoes were always showing as SentInClear due to the encryption_info not being available.

Will need a rebase after #3786 to add the code field (or vice versa).

@pixlwave pixlwave requested a review from a team as a code owner August 1, 2024 11:12
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 1, 2024 11:12
@pixlwave pixlwave changed the title sdk-ui: Fix a bug where local echoes were showing unencrypted shields. Timeline: Fix a bug where local echoes were showing unencrypted shields. Aug 1, 2024
@stefanceriu stefanceriu enabled auto-merge (rebase) August 1, 2024 11:25
@stefanceriu stefanceriu merged commit aee8728 into main Aug 1, 2024
40 checks passed
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.03%. Comparing base (bfa069d) to head (dca9849).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3788      +/-   ##
==========================================
+ Coverage   84.02%   84.03%   +0.01%     
==========================================
  Files         259      259              
  Lines       27159    27159              
==========================================
+ Hits        22819    22824       +5     
+ Misses       4340     4335       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants