Implement CI to detect long path in pushed commit #4637
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4637 +/- ##
=======================================
Coverage 85.89% 85.90%
=======================================
Files 292 292
Lines 33914 33914
=======================================
+ Hits 29131 29134 +3
+ Misses 4783 4780 -3 ☔ View full report in Codecov by Sentry. |
andybalaam
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Thanks for working on this!
This looks good, but the "Files changed" view shows that it adds a file that doesn't seem relevant: crates/matrix-sdk-common/src/snapshots/ci_test-matrix_sdk_common__deserialized_responses__tests__snapshot_test_algorithm_info.snap.
Ah, and I see that is breaking CI. So probably this was deliberate, to test it works, but please now revert that part so we can merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will implement file path checker in github actions CI, so that developer can find long path issue on every PR.
This proposal was from @richvdh .
This PR is a sequel to #4625.