Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oidc): Move qrcode module inside oidc #4687

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Feb 19, 2025

Because it uses the OIDC API and it is accessed via Oidc::login_with_qr_code().

The second commit makes LoginWithQrCode use OidcBackend instead of its own OauthClient. It will allow to share code when the server backend is switched to the oauth2 crate too. It will also allow to expose the device authorization grant directly in Oidc, if necessary.

Will allow to share code when the backend is switched to the oauth2 crate too.

It will also allow to expose the device authorization grant directly in Oidc, if necessary.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner February 19, 2025 10:08
@zecakeh zecakeh requested review from Hywan and removed request for a team February 19, 2025 10:08
@poljar poljar requested review from poljar and removed request for Hywan February 19, 2025 10:10
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.87%. Comparing base (2eb2ae7) to head (1b3f35a).

Files with missing lines Patch % Lines
...matrix-sdk/src/authentication/oidc/qrcode/login.rs 76.47% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4687      +/-   ##
==========================================
- Coverage   85.89%   85.87%   -0.02%     
==========================================
  Files         292      291       -1     
  Lines       33912    33930      +18     
==========================================
+ Hits        29129    29139      +10     
- Misses       4783     4791       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant