refactor(oidc): Align OidcAuthCodeUrlBuilder behavior with next-gen auth MSCs
#4699
+23
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a small optimization which makes the URL smaller, but it is not part of the next-gen auth MSCs and is not supported by the oauth2 crate, so let's drop it. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
changed the title
AuthCodeUrlBuilder behavior with next-gen auth MSCsOidcAuthCodeUrlBuilder behavior with next-gen auth MSCs
…MSCs `prompt=create` is defined in MSC2964, and `login_hint=mxid:@user:server.name` is defined in MSC4198. The other parameters came from OpenID Connect. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
changed the title
OidcAuthCodeUrlBuilder behavior with next-gen auth MSCsOidcAuthCodeUrlBuilder behavior with next-gen auth MSCs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4699 +/- ##
==========================================
+ Coverage 85.89% 85.99% +0.10%
==========================================
Files 292 292
Lines 33909 33855 -54
==========================================
- Hits 29126 29114 -12
+ Misses 4783 4741 -42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes support for Pushed Authorization Requests. PAR is a small optimization that sends the parameters via a request first, and returns an ID that we used in the authorization URL instead of the parameters, so it only makes the authorization URL smaller by reducing the size of the query part. It is no mentioned in the next-gen auth MSCs and it is not supported by the oauth2 crate so let's remove it already.
The second commit removes most of the optional parameters of the authorization URL. All those parameters are specified in OpenID Connect, but the next-gen auth MSCs were downgraded to OAuth 2.0 which doesn't have those parameters.
Only the following parameters are defined in the MSCs:
prompt=createis defined in MSC2964login_hint=mxid:@user:server.nameis defined in MSC4198