test: rename some MatrixMockServer matcher functions #4701
+36
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
force-pushed
the
bnjbvr/rename-matrix-mock-server-helpers
branch
from
73e038d to
2f320fa
Compare
poljar
approved these changes
Feb 20, 2025
| @@ -1387,7 +1387,7 @@ impl<'a> MockEndpoint<'a, RoomSendEndpoint> { | |||
| /// assert_eq!("$some_id", response.delay_id); | |||
| /// # anyhow::Ok(()) }); | |||
| /// ``` | |||
| pub fn with_delay(self, delay: Duration) -> Self { | |||
| pub fn match_delay(self, delay: Duration) -> Self { | |||
There was a problem hiding this comment.
Perhaps match_delayted_event() would be an even better name, also the docs should really link to the MSC.
| @@ -1615,7 +1615,7 @@ impl<'a> MockEndpoint<'a, RoomSendStateEndpoint> { | |||
| /// | |||
| /// # anyhow::Ok(()) }); | |||
| /// ``` | |||
| pub fn with_delay(self, delay: Duration) -> Self { | |||
| pub fn match_delay(self, delay: Duration) -> Self { | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4701 +/- ##
=======================================
Coverage 85.90% 85.90%
=======================================
Files 292 292
Lines 33907 33907
=======================================
Hits 29127 29127
Misses 4780 4780 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/rename-matrix-mock-server-helpers
branch
from
2f320fa to
f503321
Compare
… they're matchers The `.from()`, `.with_delay()` and `.limit()` functions are not very explicit about what they did, and the `with_delay` one in particular led me to think that it would introduce a delay *in the response*, while it indicated a delay was expected as part of the matched URL. Instead, this patch proposes to prefix all matchers with `match_`, to make it clearer that… they will match the incoming query: match_from, match_delay, match_limit. Thanks to this change, the `RoomMessagesResponseTemplate` can be renamed from `delayed` to `with_delay`, which was my original intent, before I noticed another `with_delay` with totally different semantics.
bnjbvr
force-pushed
the
bnjbvr/rename-matrix-mock-server-helpers
branch
from
f503321 to
20e6bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.from(),.with_delay()and.limit()functions are not very explicit about what they did, and thewith_delayone in particular led me to think that it would introduce a delay in the response, while it indicated a delay was expected as part of the matched URL.Instead, this patch proposes to prefix all matchers with
match_, to make it clearer that… they will match the incoming query: match_from, match_delay, match_limit.Thanks to this change, the
RoomMessagesResponseTemplatecan be renamed fromdelayedtowith_delay, which was my original intent, before I noticed anotherwith_delaywith totally different semantics.