feat: added vm.keyExistsJson #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MexicanAce
reviewed
May 23, 2024
|
@PatrickAlphaC some cheatcodes are missing as we haven't sync'd with upstream foundry yet since March. We're currently in the process of merging upstream. When that happens, the new cheatcodes would automatically be supported. I'd defer this PR for the time being as it can cause additional merge conflicts, thereby delaying the upstream merge. |
|
This is also bothering us. Would be great to see another upstream merge (plus |
|
Yeah we'll be on it once #368 gets merged, since it's a pre-requisite for the upstream merge. |
2 tasks
|
This is now supported thanks to #445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I need this to deploy smart contracts. It seems odd that some of the supported VM cheatcodes are missing right now.
Solution