-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-147] Updated log statements #444
base: master
Are you sure you want to change the base?
Conversation
…ab into verbose-logging-for-token-debugging
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
- Coverage 34.02% 33.40% -0.62%
==========================================
Files 22 22
Lines 4021 4185 +164
==========================================
+ Hits 1368 1398 +30
- Misses 2515 2647 +132
- Partials 138 140 +2 ☔ View full report in Codecov by Sentry. |
@mickmister Gentle reminder for review |
I'm not sure if we should go through with this logging approach in general. @hanzei What are your thoughts on this? |
The diff looks off. Maybe the PR needs to get rebased onto |
@hanzei The branch |
@raghavaggarwal2308 We can have this PR point to |
@mickmister updated |
Summary