Web's env + wip email #1547
oscartbeaumontci.yaml
on: push
Typecheck
42s
Migrations
39s
Format & Lint (Biome)
25s
Format (Cargo)
8s
Clippy
2m 24s
Annotations
4 errors and 12 warnings
|
Typecheck:
apps/landing/src/routes/docs.tsx#L12
Cannot find module 'content-collections' or its corresponding type declarations.
|
|
Typecheck:
apps/landing/src/routes/docs/[...rest].tsx#L2
Cannot find module 'content-collections' or its corresponding type declarations.
|
|
Typecheck:
apps/landing/src/routes/docs/[...rest].tsx#L12
Parameter 'd' implicitly has an 'any' type.
|
|
Typecheck
Process completed with exit code 2.
|
|
Format & Lint (Biome)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Migrations
The following actions use a deprecated Node.js version and will be forced to run on node20: pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
unused import: `MICROSOFT_DEVICE_ID_EXTENSION`:
crates/mx-manage/src/enrollment.rs#L18
warning: unused import: `MICROSOFT_DEVICE_ID_EXTENSION`
--> crates/mx-manage/src/enrollment.rs:18:67
|
18 | ENROLLMENT_REQUEST_TYPE_ISSUE, ENROLLMENT_REQUEST_TYPE_RENEW, MICROSOFT_DEVICE_ID_EXTENSION,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unreachable expression:
crates/mx-manage/src/manage.rs#L20
warning: unreachable expression
--> crates/mx-manage/src/manage.rs:20:21
|
20 | return todo!();
| ^^^^^^^-------
| | |
| | any code following this expression is unreachable
| unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
|
|
constant `OS_WINDOWS` is never used:
crates/mx-manage/src/enrollment.rs#L37
warning: constant `OS_WINDOWS` is never used
--> crates/mx-manage/src/enrollment.rs:37:7
|
37 | const OS_WINDOWS: &str = "Windows";
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
field `appru` is never read:
crates/mx-manage/src/enrollment.rs#L41
warning: field `appru` is never read
--> crates/mx-manage/src/enrollment.rs:41:9
|
40 | pub struct AuthQueryParams {
| --------------- field in this struct
41 | pub appru: String,
| ^^^^^
|
|
used `unwrap_or_else()` on `Some` value:
crates/mx-manage/src/enrollment.rs#L354
warning: used `unwrap_or_else()` on `Some` value
--> crates/mx-manage/src/enrollment.rs:354:31
|
354 | _ => ("User", upn.unwrap_or_else(|| "system".to_string()).clone(), ENROLLMENT_TYPE_USER),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: remove the `Some` and `unwrap_or_else()`
--> crates/mx-manage/src/enrollment.rs:350:23
|
350 | let upn = Some("[email protected]".to_string()); // TODO: Work this out properly
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
= note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
crates/mx-manage/src/enrollment.rs#L403
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/mx-manage/src/enrollment.rs:403:45
|
403 | let certificate = csr.signed_by(&identity_cert, &identity_key).unwrap(); // TODO: Error handling
| ^^^^^^^^^^^^^^ help: change this to: `identity_cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
crates/mx-manage/src/enrollment.rs#L403
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/mx-manage/src/enrollment.rs:403:61
|
403 | let certificate = csr.signed_by(&identity_cert, &identity_key).unwrap(); // TODO: Error handling
| ^^^^^^^^^^^^^ help: change this to: `identity_key`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
sub-expression diverges:
rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/macros/mod.rs#L899
warning: sub-expression diverges
--> crates/mx-manage/src/manage.rs:20:28
|
20 | return todo!();
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
= note: `#[warn(clippy::diverging_sub_expression)]` on by default
= note: this warning originates in the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
direct implementation of `ToString`:
crates/ms-ddf/src/ddf_v2.rs#L135
warning: direct implementation of `ToString`
--> crates/ms-ddf/src/ddf_v2.rs:135:1
|
135 | / impl ToString for DFFormatVariant {
136 | | fn to_string(&self) -> String {
137 | | match self {
138 | | DFFormatVariant::Base64 => "b64".to_string(),
... |
150 | | }
151 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
|
this seems like a manual implementation of the non-exhaustive pattern:
apps/mattraxd/src/cli/mod.rs#L13
warning: this seems like a manual implementation of the non-exhaustive pattern
--> apps/mattraxd/src/cli/mod.rs:13:1
|
13 | pub struct Cli {
| ^-------------
| |
| _help: add the attribute: `#[non_exhaustive] pub struct Cli`
| |
14 | | #[arg(short, long)]
15 | | pub data_dir: Option<PathBuf>,
... |
22 | | pub command: Commands,
23 | | }
| |_^
|
help: remove this field
--> apps/mattraxd/src/cli/mod.rs:19:5
|
19 | version: (),
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
= note: `#[warn(clippy::manual_non_exhaustive)]` on by default
|