Skip to content

v2

v2 #1568

Triggered via pull request September 19, 2024 04:54
@oscartbeaumontoscartbeaumont
synchronize #415
v2
Status Failure
Total duration 2m 38s
Artifacts

ci.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

19 errors and 12 warnings
Format & Lint (Biome)
Process completed with exit code 1.
Typecheck: packages/policy-composer/src/Windows.tsx#L317
Right operand of ?? is unreachable because the left operand is never nullish.
Typecheck: apps/web/src/api/index.ts#L4
Module '"~/db"' has no exported member 'UserProviderVariant'.
Typecheck: apps/web/src/api/trpc/routers/blueprint.ts#L20
'data' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
Typecheck: apps/web/src/components/StandardTable.tsx#L175
Type '"iconSmall"' is not assignable to type '"default" | "icon" | "sm" | "lg" | null | undefined'.
Typecheck: apps/web/src/components/Table/index.tsx#L283
Property 'name' does not exist on type 'T'.
Typecheck: apps/web/src/components/Table/index.tsx#L403
Type 'string' is not assignable to type 'boolean | undefined'.
Typecheck: apps/web/src/components/Table/index.tsx#L424
Type 'string' is not assignable to type 'boolean | undefined'.
Typecheck: apps/web/src/lib/createCollectedGenerator.tsx#L63
Property 'state' does not exist on type '{}'.
Typecheck: apps/landing/src/routes/docs.tsx#L12
Cannot find module 'content-collections' or its corresponding type declarations.
Typecheck: apps/landing/src/routes/docs/[...rest].tsx#L2
Cannot find module 'content-collections' or its corresponding type declarations.
unresolved imports `mx_db::CreatePolicyDeployStatus`, `mx_db::GetDeviceResult`: crates/mx-windows/src/policies.rs#L6
error[E0432]: unresolved imports `mx_db::CreatePolicyDeployStatus`, `mx_db::GetDeviceResult` --> crates/mx-windows/src/policies.rs:6:13 | 6 | use mx_db::{CreatePolicyDeployStatus, Db, GetDeviceResult}; | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ no `GetDeviceResult` in the root | | | no `CreatePolicyDeployStatus` in the root
unresolved imports `mx_db::GetPendingDeployStatusesResult`, `mx_db::GetPolicyDataForCheckinResult`: crates/mx-windows/src/policies.rs#L7
error[E0432]: unresolved imports `mx_db::GetPendingDeployStatusesResult`, `mx_db::GetPolicyDataForCheckinResult` --> crates/mx-windows/src/policies.rs:7:13 | 7 | use mx_db::{GetPendingDeployStatusesResult, GetPolicyDataForCheckinResult}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `GetPolicyDataForCheckinResult` in the root | | | no `GetPendingDeployStatusesResult` in the root
no method named `get_device` found for reference `&mx_db::Db` in the current scope: crates/mx-windows/src/lib.rs#L45
error[E0599]: no method named `get_device` found for reference `&mx_db::Db` in the current scope --> crates/mx-windows/src/lib.rs:45:10 | 44 | let Some(device) = db | ________________________- 45 | | .get_device(mdm_device_id) | | -^^^^^^^^^^ method not found in `&mx_db::Db` | |_________| |
no method named `update_device_lastseen` found for reference `&mx_db::Db` in the current scope: crates/mx-windows/src/lib.rs#L94
error[E0599]: no method named `update_device_lastseen` found for reference `&mx_db::Db` in the current scope --> crates/mx-windows/src/lib.rs:94:20 | 94 | db.update_device_lastseen(device.pk).await.unwrap(); // TODO: Error handling | ^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mx_db::Db`
no method named `get_policy_data_for_checkin` found for reference `&mx_db::Db` in the current scope: crates/mx-windows/src/policies.rs#L21
error[E0599]: no method named `get_policy_data_for_checkin` found for reference `&mx_db::Db` in the current scope --> crates/mx-windows/src/policies.rs:21:20 | 21 | let scope = db.get_policy_data_for_checkin(device.pk).await.unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mx_db::Db`
no method named `get_pending_deploy_statuses` found for reference `&mx_db::Db` in the current scope: crates/mx-windows/src/policies.rs#L22
error[E0599]: no method named `get_pending_deploy_statuses` found for reference `&mx_db::Db` in the current scope --> crates/mx-windows/src/policies.rs:22:38 | 22 | let pending_deploy_statuses = db.get_pending_deploy_statuses(device.pk).await.unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mx_db::Db`
no method named `create_policy_deploy_status` found for reference `&mx_db::Db` in the current scope: crates/mx-windows/src/policies.rs#L171
error[E0599]: no method named `create_policy_deploy_status` found for reference `&mx_db::Db` in the current scope --> crates/mx-windows/src/policies.rs:171:8 | 171 | db.create_policy_deploy_status(policy_deploy_statuses.into_values().collect()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mx_db::Db`
Clippy
Clippy had exited with the 101 exit code
Format & Lint (Biome)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Migrations
The following actions use a deprecated Node.js version and will be forced to run on node20: pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
unused import: `MICROSOFT_DEVICE_ID_EXTENSION`: crates/mx-manage/src/enrollment.rs#L18
warning: unused import: `MICROSOFT_DEVICE_ID_EXTENSION` --> crates/mx-manage/src/enrollment.rs:18:67 | 18 | ENROLLMENT_REQUEST_TYPE_ISSUE, ENROLLMENT_REQUEST_TYPE_RENEW, MICROSOFT_DEVICE_ID_EXTENSION, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unreachable expression: crates/mx-manage/src/manage.rs#L20
warning: unreachable expression --> crates/mx-manage/src/manage.rs:20:21 | 20 | return todo!(); | ^^^^^^^------- | | | | | any code following this expression is unreachable | unreachable expression | = note: `#[warn(unreachable_code)]` on by default
constant `OS_WINDOWS` is never used: crates/mx-manage/src/enrollment.rs#L37
warning: constant `OS_WINDOWS` is never used --> crates/mx-manage/src/enrollment.rs:37:7 | 37 | const OS_WINDOWS: &str = "Windows"; | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
field `appru` is never read: crates/mx-manage/src/enrollment.rs#L41
warning: field `appru` is never read --> crates/mx-manage/src/enrollment.rs:41:9 | 40 | pub struct AuthQueryParams { | --------------- field in this struct 41 | pub appru: String, | ^^^^^
used `unwrap_or_else()` on `Some` value: crates/mx-manage/src/enrollment.rs#L354
warning: used `unwrap_or_else()` on `Some` value --> crates/mx-manage/src/enrollment.rs:354:31 | 354 | _ => ("User", upn.unwrap_or_else(|| "system".to_string()).clone(), ENROLLMENT_TYPE_USER), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: remove the `Some` and `unwrap_or_else()` --> crates/mx-manage/src/enrollment.rs:350:23 | 350 | let upn = Some("[email protected]".to_string()); // TODO: Work this out properly | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/mx-manage/src/enrollment.rs#L403
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/mx-manage/src/enrollment.rs:403:45 | 403 | let certificate = csr.signed_by(&identity_cert, &identity_key).unwrap(); // TODO: Error handling | ^^^^^^^^^^^^^^ help: change this to: `identity_cert` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/mx-manage/src/enrollment.rs#L403
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/mx-manage/src/enrollment.rs:403:61 | 403 | let certificate = csr.signed_by(&identity_cert, &identity_key).unwrap(); // TODO: Error handling | ^^^^^^^^^^^^^ help: change this to: `identity_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
sub-expression diverges: rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/macros/mod.rs#L899
warning: sub-expression diverges --> crates/mx-manage/src/manage.rs:20:28 | 20 | return todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
direct implementation of `ToString`: crates/ms-ddf/src/ddf_v2.rs#L135
warning: direct implementation of `ToString` --> crates/ms-ddf/src/ddf_v2.rs:135:1 | 135 | / impl ToString for DFFormatVariant { 136 | | fn to_string(&self) -> String { 137 | | match self { 138 | | DFFormatVariant::Base64 => "b64".to_string(), ... | 150 | | } 151 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `#[warn(clippy::to_string_trait_impl)]` on by default
this seems like a manual implementation of the non-exhaustive pattern: apps/mattraxd/src/cli/mod.rs#L13
warning: this seems like a manual implementation of the non-exhaustive pattern --> apps/mattraxd/src/cli/mod.rs:13:1 | 13 | pub struct Cli { | ^------------- | | | _help: add the attribute: `#[non_exhaustive] pub struct Cli` | | 14 | | #[arg(short, long)] 15 | | pub data_dir: Option<PathBuf>, ... | 22 | | pub command: Commands, 23 | | } | |_^ | help: remove this field --> apps/mattraxd/src/cli/mod.rs:19:5 | 19 | version: (), | ^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive = note: `#[warn(clippy::manual_non_exhaustive)]` on by default