fallback if snap is targetted (#200)

* fallback if snap is targetted

* put code in subfunctions

---------

Co-authored-by: Jean-Loup Maillet <[email protected]>

src/browser.rs

@@ -159,7 +159,7 @@ impl Browser {
     /// (20 seconds by default).
     pub async fn launch(mut config: BrowserConfig) -> Result<(Self, Handler)> {
         // Canonalize paths to reduce issues with sandboxing
-        config.executable = utils::canonicalize(&config.executable).await?;
+        config.executable = utils::canonicalize_except_snap(config.executable).await?;
 
         // Launch a new chromium instance
         let mut child = config.launch()?;

src/utils.rs

@@ -29,6 +29,24 @@ pub(crate) async fn canonicalize<P: AsRef<Path> + Unpin>(path: P) -> std::io::Re
     Ok(dunce::simplified(&path).to_path_buf())
 }
 
+/// Absolute path
+///
+pub(crate) fn absolute(path: PathBuf) -> std::io::Result<PathBuf> {
+    let path = if path.is_absolute() { path } else { std::env::current_dir()?.join(path) };
+    Ok(dunce::simplified(&path).to_path_buf())
+}
+
+/// Canonicalize path except if target binary is snap, in this case only make the path absolute
+///
+pub(crate) async fn canonicalize_except_snap(path: PathBuf) -> std::io::Result<PathBuf> {
+    // Canonalize paths to reduce issues with sandboxing
+    let executable_cleaned: PathBuf = canonicalize(&path).await?;
+
+    // Handle case where executable is provided by snap, ignore canonicalize result and only make path absolute
+    Ok(if executable_cleaned.to_str().unwrap().ends_with("/snap") { absolute(path).unwrap() } else { executable_cleaned })
+}
+
+
 pub(crate) mod base64 {
     use base64::engine::general_purpose::STANDARD;
     use base64::{DecodeError, Engine};