Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto find websocket address and handle bytes #176

Closed
wants to merge 14 commits into from
Closed

Auto find websocket address and handle bytes #176

wants to merge 14 commits into from

Conversation

j-mendez
Copy link
Contributor

@j-mendez j-mendez commented Sep 20, 2023 •
edited
Loading

  • add valid bytes handling of resources ( allows storing correctly non ut8 to disk ).
  • add websocket address connecting
  • add unix chrome paths
  • allow stealth pass in dynamic UA for non static content

@j-mendez
Copy link
Contributor Author

Feel free to make adjustments to the PR to fit the needs of the crate.

mattsse
mattsse requested changes Sep 26, 2023
View reviewed changes
Copy link
Owner

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the dealy...

generally supportive, but would like to introduce these changes as separate additional functions

src/page.rs Outdated Show resolved Hide resolved
src/page.rs Show resolved Hide resolved
src/browser.rs Outdated Show resolved Hide resolved
src/browser.rs Show resolved Hide resolved
src/browser.rs Outdated Show resolved Hide resolved
@j-mendez
Copy link
Contributor Author

j-mendez commented Oct 6, 2023

@mattsse good feedback, going to get to the rest of the changes by tomorrow or the weekend.

@j-mendez j-mendez requested a review from mattsse October 22, 2023 12:01
mattsse
mattsse approved these changes Nov 6, 2023
View reviewed changes
Copy link
Owner

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, sorry for the delay.

I changed my mind on this and combined the connect functions, checking for HTTP is reasonable, and less confusing than having to separate functions

@mattsse mattsse mentioned this pull request Nov 6, 2023
Merged
@mattsse
Copy link
Owner

mattsse commented Nov 6, 2023

superseded by #188 because can't push manual changes to main

@mattsse mattsse closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mendez @mattsse