Skip WebSocket message parsing errors #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattsse I think we need to get this merged at some point, I saw it a couple of times too depending on the browser version. |
|
This may have to be reworked such that it has no dependencies on the other PRs to move it forward, as the dependency PR seems to be stuck. |
MOZGIII
force-pushed
the
skip-parsing-errors
branch
from
ce65792
to
2c9ba9f
Compare
|
@MOZGIII Would you mind rebasing it |
|
Nah, I've had enough rebasing - feel free to take care of it if you want it |
|
uff, very sorry for not getting to this in time -.- @Sytten I assume this is still an issue? |
|
I see #243 getting this in now |
|
Yeah but I will push a PR tomorrow to merge a few of the PR |
|
We also need a variant of #206 but I wanted to rewrite it. |
mattsse
approved these changes
Oct 24, 2024
Sytten
added a commit
to caido/dependency-chromiumoxide
that referenced
this pull request
Oct 24, 2024
This reverts commit c955148.
Sytten
added a commit
to caido/dependency-chromiumoxide
that referenced
this pull request
Oct 24, 2024
This reverts commit c955148.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167.