Proposition: don't wait for Keycloak's initialization #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Improved setup instructions.
What is the current behavior?
Currently if 3rd party cookies are disabled (e.g. on Safari) when opening Keycloak-secured app using 'check-sso' on load, app initialization NEVER completes when
silentCheckSsoFallback
is turned off or redirects user to login page (which can be just an "Invalid credentials" error page when login+password login is disabled) and he can never go back, because of this immediate redirect.There's an underlaying issue in
keycloak-js
, which doesn't handle failedGET /realms/${realmName}/protocol/openid-connect/auth
request correctly, just silences it.Issue Number: #544
What is the new behavior?
App doesn't wait for Keycloak initialization, so it doesn't break, but it may not be a proper solution when using `onLoad: 'login-required'
Does this PR introduce a breaking change?
Screen recording of described behaviors